Skip to content

Azure Load Balancer notes #16456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Azure Load Balancer notes #16456

wants to merge 3 commits into from
+33 −0

Conversation

Stevenjin8
Copy link
Contributor

Description

Band aid for istio/istio#46769

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

@istio-testing
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@istio-testing istio-testing added do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 7, 2025
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 7, 2025
@Stevenjin8 Stevenjin8 mentioned this pull request May 8, 2025
Open
2 tasks
@Stevenjin8 Stevenjin8 marked this pull request as ready for review May 9, 2025 19:39
@Stevenjin8 Stevenjin8 requested a review from a team as a code owner May 9, 2025 19:39
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label May 9, 2025
@Stevenjin8
Copy link
Contributor Author

todo, add a section on infra labels

@istio-testing
Copy link
Contributor

@Stevenjin8: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
lint_istio.io b741c88 link true /test lint
doc.test.profile-demo_istio.io b741c88 link true /test doc.test.profile-demo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

craigbox
craigbox reviewed May 15, 2025
View reviewed changes
content/en/docs/ambient/getting-started/deploy-sample-app/index.md
@@ -61,6 +61,14 @@ bookinfo-gateway istio bookinfo-gateway-istio.default.svc.cluster.local Tr

Wait for the gateway to show as programmed before continuing.

{{< tip >}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We try very hard to keep the Getting Started guides to be simple, and not full of "if this then that'. Is there any other way we can communicate this to keep it out of the "happy path"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigbox craigbox craigbox left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Stevenjin8 @istio-testing @craigbox